Re: [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c buildfailure

[Russell King]

On Thu, Sep 15, 2011 at 01:53:04PM +0200, Lars-Peter Clausen wrote:
> On 09/15/2011 01:00 PM, Russell King wrote:
> > [...]
> > We now have a sane policy: entries which aren't fully up to date are
> > automatically dropped.  Entries for which there is no platform support
> > file merged within 12 months of the entries last edit are dropped also
> > automatically dropped.
> 
> Partly unrelated, but what about these platforms which can be fully described
> with DT and don't need a platform file?

The theory is with DT is that machine_is_xxx() is no longer required,
because they're fully described by DT.  Such a kernel should not care
whether it's running on board XYZ or ABC because the differences are
wrapped up in the DT description of it.

Moreover, DT boards do not have machine IDs - their machine ID is "~0"
which will be universal for all DT using platforms.  So machine_is_xxx()
really has no meaning at all when using DT.  Basically, DT makes machine
IDs obsolete.

> The code for GTA01 is out there and could be merged into mainline, but
> I think it would be dead code since there doesn't seem to be really
> any interest in the device anymore.
> 
> So just get rid of the gta01 portions of the neo1973_wm8753 driver.
> If GTA01 support ever gets merged we can still revert the removal.

Agreed.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/