Re: [PATCH] iommu/omap: Fix build error with !IOMMU_SUPPORT

[Ohad Ben-Cohen]

On Wed, Sep 14, 2011 at 5:07 PM, Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> Without this patch it is possible to select the VIDEO_OMAP3
> driver which then selects OMAP_IOVMM. But the omap iommu
> driver is not compiled without IOMMU_SUPPORT enabled. Fix
> that by forcing OMAP_IOMMU and OMAP_IOVMM are enabled before
> VIDEO_OMAP3 can be selected.

I'm ok with this but wouldn't it be simpler if we drop IOMMU_SUPPORT
altogether (and just use a plain menu instead) ?

Users will then be presented with only a single iommu-related
question: whether they want their iommu driver built or not.

Something like this:

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index d901930..7d6e5ad 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -2,16 +2,7 @@
 config IOMMU_API
        bool

-menuconfig IOMMU_SUPPORT
-       bool "IOMMU Hardware Support"
-       default y
-       ---help---
-         Say Y here if you want to compile device drivers for IO Memory
-         Management Units into the kernel. These devices usually allow to
-         remap DMA requests and/or remap interrupts from other devices on the
-         system.
-
-if IOMMU_SUPPORT
+menu "IOMMU Hardware Support"

 # MSM IOMMU support
 config MSM_IOMMU
@@ -126,4 +117,4 @@ config OMAP_IOMMU_DEBUG

          Say N unless you know you need this.

-endif # IOMMU_SUPPORT
+endmenu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/