Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx

[Jens Axboe]

On 2011-09-12 17:02, Christoph Hellwig wrote:
> On Fri, Sep 09, 2011 at 10:58:01AM +0200, Jens Axboe wrote:
>>>    Documentation/block/writeback_cache_control.txt file is the canonical
>>>    resource.  Implementing your driver at the make_request layer
>>>    unfortunately means you will have to do all the hard work yourself.
>>>  - also the call to blk_queue_flush(queue, 0); from ->make_request for
>>>    a non-data request is completely wrong.
>>
>> I noticed both of these flush/fua problems too and have fixed them up.
> 
> I still can't find any fixes in your repository.

It wasn't/isn't done, it's still sitting on the test box. I'll wrap it
up tomorrow.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/