Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout

[Takashi Iwai]

At Mon, 29 Aug 2011 19:52:09 +0530,
Jassi Brar wrote:
> 
> On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@xxxxxxxxxx> wrote:
> 
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= val_len) {
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= 0) {
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â value, index + 2, NULL, 0, 1000);
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â jacks[i].unitid << 8, buf, 3, 1000);
> >> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â 50, 0, &new_status, 1, 1000);
> >>
> >> How about also converting to use a local define for timeout value ?
> >
> > ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value,
> > we could just as well drop this parameter.
> Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!

Indeed, I'd like to see the reduced arguments, too.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/