Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx

From: Christoph Hellwig
Date: Fri Sep 09 2011 - 05:03:06 EST


On Fri, Sep 09, 2011 at 10:58:01AM +0200, Jens Axboe wrote:
> > - also the call to blk_queue_flush(queue, 0); from ->make_request for
> > a non-data request is completely wrong.
>
> I noticed both of these flush/fua problems too and have fixed them up.

Where? Remember that sequencing a pre-flush in a make_request driver
is fairly complicated.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/