Re: [alsa-devel] [PATCH] ASoC: omap: convert per-board modules toplatform drivers

From: Mans Rullgard
Date: Thu Sep 08 2011 - 20:42:16 EST


On 8 September 2011 17:37, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Sep 08, 2011 at 04:41:30PM +0100, Mans Rullgard wrote:
>> On 8 September 2011 16:15, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>
>> > Use different device driver names for different drivers.
>
>> I guess this worked by accident on my system.
>
>> Are there any other changes needed?
>
> Check the N810 code - it looks like that driver should be taking
> platform data to distinguish between the two models.  Possibly also rx51
> though I only looked at the diff.  Also it should probably be grabbing
> the clocks before it registers the card.

I don't see any what would need to distinguish models. The current code
is not doing anything like that. If it should, that's a separate issue.
Agree on the clocks for N810.

--
Mans Rullgard
Multimedia
mans.rullgard@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/