Re: [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONScode

[Oleg Nesterov]

On 09/08, Denys Vlasenko wrote:
>
> On Thu, Sep 8, 2011 at 2:06 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > And it would be great if it explains what the historical bug was and
> > what the intended behavior is.

ptrace_setoptions() always changes ->ptrace, even if it returns
-EINVAL later.

> I'd rather nuke the bug in a follow-up patch (by deleting this line).

Denys, I think it would be much better to send 1/2 which fixes this oddity.

And note that this patch is wrong, I'll comment v3.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/