Re: [PATCH 2/2] mm: Add comment explaining task state setting inbdi_forker_thread()

From: Wu Fengguang
Date: Wed Sep 07 2011 - 20:29:52 EST


> grammar can often be fixed/improved by deleting stuff ;)
>
> --- a/mm/backing-dev.c~mm-add-comment-explaining-task-state-setting-in-bdi_forker_thread-fix
> +++ a/mm/backing-dev.c
> @@ -404,9 +404,8 @@ static int bdi_forker_thread(void *ptr)
> /*
> * In the following loop we are going to check whether we have
> * some work to do without any synchronization with tasks
> - * waking us up to do work for them. So we have to set task
> - * state already here so that we don't miss wakeups coming
> - * after we verify some condition.
> + * waking us up to do work for them. Set the task state here
> + * so that we don't miss wakeups after verifying conditions.
> */
> set_current_state(TASK_INTERRUPTIBLE);

That's nice and readable, thanks!

Regards,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/