Re: [PATCH 1/2] lis3lv02d: Fix read() call in lis3lv02d_get_odr()

[Andrew Morton]

On Tue,  6 Sep 2011 00:12:28 -0700
Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> The driver is passing a struct lis3lv02d ** to the read() operation but
> the read() operation wants a struct lis3lv02d * causing compiler warnings
> and presumably also runtime problems.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
>  drivers/misc/lis3lv02d/lis3lv02d.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c
> index e67dcea..72a1f92 100644
> --- a/drivers/misc/lis3lv02d/lis3lv02d.c
> +++ b/drivers/misc/lis3lv02d/lis3lv02d.c
> @@ -200,7 +200,7 @@ static int lis3lv02d_get_odr(struct lis3lv02d *lis3)
>  	u8 ctrl;
>  	int shift;
>  
> -	lis3->read(&lis3, CTRL_REG1, &ctrl);
> +	lis3->read(lis3, CTRL_REG1, &ctrl);
>  	ctrl &= lis3->odr_mask;
>  	shift = ffs(lis3->odr_mask) - 1;
>  	return lis3->odrs[(ctrl >> shift)];

This not applicable to mainline or to -stable.  It is a fix to
lis3-remove-the-references-to-the-global-variable-in-core-driver.patch
which I already have queued, as
lis3-remove-the-references-to-the-global-variable-in-core-driver-fix.patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/