RE: [PATCH] [media] at91: add code to initialize and manage theISI_MCK for Atmel ISI driver.

[Wu, Josh]

Hi, Russell

On 09/05/2011 6:34 PM Russell King wrote:

> On Mon, Sep 05, 2011 at 06:29:53PM +0800, Josh Wu wrote:
>> +static int initialize_mck(struct atmel_isi *isi,
>> +			struct isi_platform_data *pdata)
>> +{
>> +	int ret;
>> +	struct clk *pck_parent;
>> +
>> +	if (!strlen(pdata->pck_name) || !strlen(pdata->pck_parent_name))
>> +		return -EINVAL;
>> +
>> +	/* ISI_MCK is provided by PCK clock */
>> +	isi->mck = clk_get(NULL, pdata->pck_name);

> No, this is not how you use the clk API.  You do not pass clock names via
> platform data.

> You pass clk_get() the struct device.  You then pass clk_get() a
> _connection id_ on that _device_ if you have more than one struct clk
> associated with the _device_.  You then use clkdev to associate the
> struct device plus the connection id with the appropriate struct clk.

I think I missed the struct device when called clk_get(). I will fix it in v2 version.

Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/