Re: [PATCH] cris: lower the printk level in cris serial driver

[Geert Uytterhoeven]

On Thu, Sep 1, 2011 at 08:14, WANG Cong <xiyou.wangcong@xxxxxxxxx> wrote:
> KERN_CRIT is too high, replace those KERN_CRIT with KERN_ERR or KERN_INFO.
>
> Cc: Mikael Starvik <starvik@xxxxxxxx>
> Cc: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
>
> ---
> diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
> index 225123b..77ba4ed 100644
> --- a/drivers/tty/serial/crisv10.c
> +++ b/drivers/tty/serial/crisv10.c
> @@ -1788,7 +1788,7 @@ static unsigned int handle_descr_data(struct e100_serial *info,
> Â Â Â Âstruct etrax_recv_buffer *buffer = phys_to_virt(descr->buf) - sizeof *buffer;
>
> Â Â Â Âif (info->recv_cnt + recvl > 65536) {
> - Â Â Â Â Â Â Â printk(KERN_CRIT
> + Â Â Â Â Â Â Â printk(KERN_INFO
> Â Â Â Â Â Â Â Â Â Â Â "%s: Too much pending incoming serial data! Dropping %u bytes.\n", __func__, recvl);
> Â Â Â Â Â Â Â Âreturn 0;
> Â Â Â Â}

I think dropped data warrants KERN_WARN.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/