Re: [PATCH 10/11] VFS: Cache request_queue in struct block_device

From: Vivek Goyal
Date: Fri Aug 19 2011 - 10:14:26 EST


On Thu, Aug 18, 2011 at 02:03:56PM -0700, Andi Kleen wrote:
>
> >Is the performance gain because of this one less dereference really
> >substantial.
> Yes it is measurable on a large macro benchmark.
>
> The gain is from doing the prefetch early enough, and that needs the
> additional pointer.

So it gives you extra .3% (as mentioned in your first mail). IMHO, for
.3% we should not cache extra request queue pointer.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/