Re: [PATCH][Trivial] net/wan/hdlc_ppp: remove dead goto

From: David Miller
Date: Fri Aug 19 2011 - 01:03:13 EST


From: Jesper Juhl <jj@xxxxxxxxxxxxx>
Date: Sat, 13 Aug 2011 01:39:43 +0200 (CEST)

> From: Jesper Juhl <jj@xxxxxxxxxxxxx>
>
> We'll either hit one of the case labels or the default in the switch
> and in all cases do we then 'goto out', so having 'goto out' right
> after the switch is pointless as we can never hit it - remove it.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Probably a lot cleaner to use break statements in the switch() statement
and keep this goto in place.

That's more straightforward control flow than what this thing is doing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/