Re: [PATCH] video: Add a callback 'notify_after' for backlightcontrol

[Robert Morell]

On Mon, Aug 08, 2011 at 07:05:25PM -0700, Dilan Lee wrote:
[...]
> For example, GPIO backlight_en has to be risen after pwm has been enabled
> to meet panel power on sequence defined in panel specification.

I still think this information is irrelevant/nonsensical here, and
should be omitted entirely..

[...]

>  	unsigned int		lth_brightness;
>  	int			(*notify)(struct device *,
> -					  int brightness);
> +					int brightness);

Please don't change the line above; unlike the one you added after, it
was already lined up properly with its argument list.

Otherwise,
Reviewed-by: Robert Morell <rmorell@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/