Re: [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1

From: David Rientjes
Date: Sun Jul 31 2011 - 14:50:58 EST


On Fri, 29 Jul 2011, Christoph Lameter wrote:

> > We haven't come up with a solution to keep struct page size the same but I
> > think it's a reasonable trade-off.
>

We won't be coming up with a solution to that since the alignment is a
requirement for cmpxchg16b, unfortunately.

> The change requires the page struct to be aligned to a double word
> boundary. There is actually no variable added to the page struct. Its just
> the alignment requirement that causes padding to be added after each page
> struct.
>

Well, the counters variable is added although it doesn't increase the size
of the unaligned struct page because of how it is restructured. The end
result of the alignment for CONFIG_CMPXCHG_LOCAL is that struct page will
increase from 56 bytes to 64 bytes on my config. That's a cost of 128MB
on each of my client and server 64GB machines for the netperf benchmark
for the ~2.3% speedup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/