Re: [PATCH 18/18] dmaengine/amba-pl08x: Call pl08x_free_txd() insteadof calling kfree() directly

[viresh kumar]

On 7/30/11, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> 2011/7/29 Viresh Kumar <viresh.kumar@xxxxxx>:
>
>> pl08x_prep_channel_resources() is calling kfree() directly for txd(). To
>> maintain consistency in code call pl08x_free_txd() instead.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxx>
>
> Good idea,
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yet there is a problem with this patch, as pointed by Russell.
pl08x_free_txd() must be called with channel lock taken. Will
check what can be done here.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/