Re: [PATCH 3/3] regulator: tps65023: Added support for the similiarTPS65020 chip

[Marcus Folkesson]

On 07/29/2011 04:03 PM, Mark Brown wrote:
> On Fri, Jul 29, 2011 at 03:08:54PM +0200, Marcus Folkesson wrote:
>> 2011/7/29 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
>>> On Wed, Jul 27, 2011 at 12:32:47PM +0200, Marcus Folkesson wrote:
> 
>>>> +static struct tps_driver_data tps65020_drv_data = {
>>>> +             .info = (struct tps_info *) tps65020_regs,
> 
>>> Why do you need the cast here?  I see it's in the original driver too
>>> but it looks like something that should be fixed.
> 
>> I also thought about the line, It's only for avoiding warnings from gcc.
>> But I don't really understand why gcc is warning.
> 
>> gcc output:  "warning: initialization discards qualifiers from pointer
>> target type".
> 
> It's complaining because the declaration of tps65020_regs doesn't match
> up with that of .info.  Probably the struct member needs to be a const
> pointer.


Changes from original patch:

@@ -681,19 +681,19 @@ static const struct tps_info tps65023_regs[] = {
 };
 
 static struct tps_driver_data tps65020_drv_data = {
-		.info = (struct tps_info *) tps65020_regs,
+		.info = tps65020_regs,
 		.core_regulator = TPS65023_DCDC_3,
 		.num_voltages = tps65020_num_voltages,
 };