Re: [PATCHv2] DMAEngine: Let dmac drivers to set chan_id

From: Linus Walleij
Date: Fri Jul 29 2011 - 08:20:08 EST


2011/7/29 Russell King <rmk@xxxxxxxxxxxxxxxx>:
> On Fri, Jul 29, 2011 at 12:27:58AM +0200, Linus Walleij wrote:
>> +static struct pl08x_channel_data ab926ejs_chan_data[] = {
>> +     [0] = {
>> +             .bus_id = "aacirx",
>> +             .min_signal = 0,
>> +             .max_signal = 0,
>> +             .cctl = PRIMECELL_DEFAULT_CCTL,
>> +             .ccfg = PL080_FLOW_PER2MEM << PL080_CONFIG_FLOW_CONTROL_SHIFT,
>
> Linus,
>
> We really should sync our two implementations for this - all the ccfg
> stuff should be gone from these structures, esp. as its already long
> gone from the structure itself.

Sure, it was merely an illustration. I figured you must have some code
since you've been testing it on AACI and whatnot. I'm currently in the
countryside, I plan to pick this up when I get back to the office (where
the PB11MPCore is) in mid-august.

If you have some platform data + mux code that fits with your latest
patches to the PL08x driver, then please poste to LAKML and I'll have
them tested ASAP.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/