Re: [PATCH] sunrpc: use better NUMA affinities

[Greg Banks]

Sent from my iPhone

On 29/07/2011, at 20:36, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Fri, Jul 29, 2011 at 04:53:21PM +1000, Greg Banks wrote:
> > > Check commit 94dcf29a11b3d20a (kthread: use kthread_create_on_node 
> > > ()) to
> > > see how this strategy already was adopted for ksoftirqd, kworker,
> > > migration, and pktgend kthreads.
> >
> > Ah, I see.  It's unfortunate that the kthread_create() API ends up
> > being passed a CPU number but that's only used to format the name
> > and not for sensible things :(
>
> kthread_create doesn't have a cpu argument - it has a printf-like  
> format
> string.

Sure, and a whole lot of the callsites are ("..._%d", cpu), hence the  
unfortune :(

Greg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/