Re: [RFC PATCH -tip 4/5] tracepoints: add tracepoints for pagecache

[Mel Gorman]

On Mon, Jul 18, 2011 at 05:38:03PM -0400, Keiichi KII wrote:
> From: Keiichi Kii <k-keiichi@xxxxxxxxxxxxx>
> 
> This patch adds several tracepoints to track pagecach behavior.
> These trecepoints would help us monitor pagecache usage with high resolution.
> 

There are a few spelling mistakes there but what harm. This is an RFC.

Again, it would be really nice if the changelog explained why it was
useful to monitor pagecache usage at this resolution. For example,
I could identify files with high and low hit ratios and conceivably
identify system activity that resulted in page cache being trashed.
However, even in that case, I don't necessarily care which files got
chucked out and that sort of problem can also be seen via fault rates.

Another scenario that may be useful is it could potentially identify an
application bug that was invalidating a portion of a file that was in
fact hot and in use by other processes. I'm sure you have much better
examples that motivated the development of this series :)

The tracepoints themselves look fine.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/