Re: [PATCH v2 0/6] Add tracepoints to trace all system IRQs

[Vaibhav Nagarnaik]

On Thu, Jul 28, 2011 at 7:08 AM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> On Thu, Jul 28, 2011 at 04:10:04PM +0200, Peter Zijlstra wrote:
>> On Thu, 2011-07-28 at 14:31 +0200, Frederic Weisbecker wrote:
>> >
>> > Because that requires to put the tracepoints in every interrupt sources
>> > for every archs instead of putting one in the generic space.
>>
>> To sum up from IRC, yes that's exactly what you need to do, because this
>> patch set assumes two things:
>>
>>  1) that there is a 1:1 mapping between interrupt sources and generic
>> handlers, and
>>
>>  2) that there is a neglectable amount of arch specific code for each
>> generic handler.
>>
>> Both are false in generic. Therefore there is no option but to
>> instrument each and every arch specific interrupt handler.
>>
>> Also, please use a single tracepoint for all that instead of this horrid
>> forest of random crap. Use something like arch_interrupt_enter(line_nr),
>> arch_interrupt_exit(line_nr).
>
> Right, so I guess the first iteration of the patchset was good in fact.
>

Frederic and Peter

Thanks for reviewing the patch series. I will post the first iteration
of this patch rebased to the latest HEAD.


Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/