Re: [PATCHv2] DMAEngine: Let dmac drivers to set chan_id

[Russell King]

On Thu, Jul 28, 2011 at 04:26:25PM +0530, Jaswinder Singh wrote:
> On 28 July 2011 02:07, Russell King <rmk@xxxxxxxxxxxxxxxx> wrote:
> > On Wed, Jul 27, 2011 at 08:00:23PM +0530, Jaswinder Singh wrote:
> >> On 27 July 2011 14:32, Koul, Vinod <vinod.koul@xxxxxxxxx> wrote:
> >> > You can have two different DMACs in same system. At least I have two
> >> > from current intel_mid_dma which are used. Both give their channel id
> >> > starting from 0, 1....
> >> > Further as we integrate video, audio, spi, emmc dmacs possibility of
> >> > having multiple dmacs will increase in a system
> >>
> >> Most of Samsung's S5P series have 3 DMACs - 2 for peripherals and 1 for
> >> mem->mem But that is not the point.
> >>
> >> This patch in no way affects what values currently a dmac driver
> >> assigns to chan_id
> >
> > Then *explain* how the chan_id is used to match the channel which the
> > peripheral requires when you have three DMA controllers, each with
> > channels numbered 0 to 7.
> >
> >> > Sorry I didn't get you.
> >> > As I understand you are trying to simplify the filter function by
> >> > assigning unique ids to all channels,
> >>
> >> No dear. Let me put it precisely.
> >>
> >> Even if we make no further change to the dmaengine, this patch is the right
> >> thing to do today.
> >
> > You sound like a politician.  "the right thing to do" is a cop-out.  That
> > says "believe me, I know I'm right, but I can't say why I'm right, I just
> > am."  Basically, it means that the person saying it has no clue on the
> > subject they're talking about.
> 
> Why don't you look at the _patch_ and see if it's correct or not ?
> Rather than passing judgement on my character.

Oh for fuck sake, this is absolutely useless.  I gave you specific examples
to explain your idea.  You refuse to do so.  So my conclusion is that your
idea can not satisfy those scenarios.

As my examples are based on _real_ boards which I have here, the conclusion
I come to is that your idea is completely unworkable and so doesn't warrant
even reading the code.

That's not passing judgement on your character.

Your complete refusal to explain how your idea applies to my example cases
does _by_ _itself_ pass a judgement on your character.  It doesn't require
any personal involvement on my part to achieve that.

So, all in all I am no longer interested in your obviously unworkable
solution.  So I say NAK to it _until_ you can provide me with the
explaination I've asked for.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/