Re: [PATCH] ARM: mm: cache-l2x0: Add support for re-enabling l2x0

[Barry Song]

2011/6/13 Colin Cross <ccross@xxxxxxxxxxx>:
> Remove __init annotation from l2x0_init so it can be used to
> reinitialize the l2x0 after it has been reset during suspend.

__init before l2x0_init can be deleted and make it available after resume.

We just tried the following flow for l2 cache on CSR SiRFprimaII, it
seems to be working:

suspend: sync and invalidate l2 cache, then disable L2

        v7_flush_kern_cache_all

#ifdef CONFIG_CACHE_L2X0
        ldr     r0, =SIRFSOC_L2CC_VA_BASE
        ldr     r1, =L2X0_CLEAN_INV_WAY
        mov     r2, #0xff
        str     r2, [r0,r1]
        mov     r2, #0
1:
        ldr     r3, [r0,r1]
        cmp     r2,r3
        bne     1b
        ldr     r1, =L2X0_CACHE_SYNC
        mov     r2, #0
        str     r2, [r0,r1]

        ldr     r1, =L2X0_CTRL
        mov     r2, #0
        str     r2, [r0,r1]
#endif

resume:  re-initilized l2x:

 l2x0_init((void __iomem *)SIRFSOC_L2CC_VA_BASE, 0x00040000, 0x00000000);

>
> Only print the init messages the first time l2x0_init is called.
>
> Add l2x0_enable to re-enable the l2x0 after l2x0_disable if
> the l2x0 was not reset.
>
> l2x0_disable cannot use writel, as writel calls wmb(), and wmb()
> may call outer_cache_sync, which takes the same spinlock as
> l2x0_disable.
>
> Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>
> ---
> Âarch/arm/include/asm/hardware/cache-l2x0.h | Â Â3 ++-
> Âarch/arm/mm/cache-l2x0.c          |  18 ++++++++++++++----
> Â2 files changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h
> index 16bd480..8fd87fe 100644
> --- a/arch/arm/include/asm/hardware/cache-l2x0.h
> +++ b/arch/arm/include/asm/hardware/cache-l2x0.h
> @@ -73,7 +73,8 @@
> Â#define L2X0_AUX_CTRL_EARLY_BRESP_SHIFT Â Â Â Â Â Â Â Â30
>
> Â#ifndef __ASSEMBLY__
> -extern void __init l2x0_init(void __iomem *base, __u32 aux_val, __u32 aux_mask);
> +extern void l2x0_init(void __iomem *base, __u32 aux_val, __u32 aux_mask);
> +extern void l2x0_enable(void);
> Â#endif
>
> Â#endif
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index ef59099..4db0d9c 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -261,16 +261,26 @@ static void l2x0_flush_range(unsigned long start, unsigned long end)
> Â Â Â Âspin_unlock_irqrestore(&l2x0_lock, flags);
> Â}
>
> +/* enables l2x0 after l2x0_disable, does not invalidate */
> +void l2x0_enable(void)
> +{
> + Â Â Â unsigned long flags;
> +
> + Â Â Â spin_lock_irqsave(&l2x0_lock, flags);
> + Â Â Â writel_relaxed(1, l2x0_base + L2X0_CTRL);
> + Â Â Â spin_unlock_irqrestore(&l2x0_lock, flags);
> +}
> +
> Âstatic void l2x0_disable(void)
> Â{
> Â Â Â Âunsigned long flags;
>
> Â Â Â Âspin_lock_irqsave(&l2x0_lock, flags);
> - Â Â Â writel(0, l2x0_base + L2X0_CTRL);
> + Â Â Â writel_relaxed(0, l2x0_base + L2X0_CTRL);
> Â Â Â Âspin_unlock_irqrestore(&l2x0_lock, flags);
> Â}
>

can you show your context calling l2x0_disable and l2x0_enable?

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/