Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist

From: Chris Ball
Date: Wed Jul 27 2011 - 17:47:43 EST


Hi Rafael,

On Tue, Jul 26 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@xxxxxxx>
>
> Fix build issue caused by undefined struct scatterlist in
> drivers/mmc/host/tmio_mmc.c.
>
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> ---
> drivers/mmc/host/tmio_mmc.h | 1 +
> drivers/usb/renesas_usbhs/fifo.c | 1 +
> 2 files changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> ===================================================================
> --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/pagemap.h>
> #include <linux/spinlock.h>
> +#include <linux/scatterlist.h>
>
> /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> #define TMIO_SDIO_STAT_IOIRQ 0x0001

I'm not able to reproduce the build failure here.

drivers/mmc/host/tmio_mmc.c already performs "#include <linux/scatterlist.h>"
itself (and always has done), so I'm confused about why this is necessary.
Do you have a copy of your build log with the error?

Thanks,

- Chris.
--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/