Re: [PATCHv2] DMAEngine: Let dmac drivers to set chan_id

From: Russell King
Date: Wed Jul 27 2011 - 16:29:34 EST


On Wed, Jul 27, 2011 at 10:44:53PM +0530, Jaswinder Singh wrote:
> 1) What I propose
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-July/059212.html
>
> 2) Why RMK thinks I am the biggest idiot on earth
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-July/059217.html
>
> 3) How I ask for better proof of that
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-July/059223.html

Look, your idea is completely mad and insane - you just can't represent
the matching stuff as capabilities.

How do you deal with a peripheral being linked to a _specific_ DMA
engine on a _specific_ DMA request signal? What if your system has
two DMA engines, each with 32 request signals? Are you going to have
something like a 128-bit capability mask?

Peripheral drivers don't know what DMA signal the SoC designer may have
chosen. Peripheral drivers don't know what DMA engine they're connected
to. Yet again, I say, the only place which knows that is data associated
with the _platform_. The platform has to be involved with binding the
DMA engine plus DMA channel with the peripheral. You can't get away from
that. Not with capabilities. Not with stuff from the peripheral driver
saying "I want a M2P channel" in a capability field, etc

So I think your idea is totally unworkable, and it doesn't come close to
fitting with any DMA setup I've seen.

If that means you think I'm calling you an idiot, then so be it. I just
think you're wrong on a purely technical level.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/