Re: [stable] [PATCH] bitops: Use volatile in generic atomic bitops.

From: Greg KH
Date: Wed Jul 27 2011 - 12:25:04 EST


On Wed, Jul 27, 2011 at 01:21:19PM +0100, Will Newton wrote:
> The generic atomic bitops currently explicitly cast away the
> volatile from the pointer passed to them. This will allow the
> access to the bitfield to happen outside of the critical section
> thus making the bitops no longer interrupt-safe. Remove this cast
> and add a volatile keyword to make sure all accesses to the
> bitfield happen inside the critical section.
>
> Signed-off-by: Will Newton <will.newton@xxxxxxxxxx>
> ---
> include/asm-generic/bitops/atomic.h | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/