Re: [PATCH 13/13] memblock, x86: Replacememblock_x86_reserve/free_range() with generic ones

From: Tejun Heo
Date: Wed Jul 27 2011 - 04:08:09 EST


Hello, Yinghai.

On Tue, Jul 26, 2011 at 05:59:13PM -0700, Yinghai Lu wrote:
> yes, with bootmem wrap stage, the print out are all the same.
>
> will have
> __alloc_memory_core_early+0x63
> everywhere.
>
> add name print out for comparing, name could give some hint.

The better solution would be making __alloc_memory_core_early() pass
in its caller and print it out. I don't think requiring pretty name
just for debugging is a good or scalable idea. There's no reason to
bother API users with it.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/