Re: [PATCH v3] blk-cgroup:be able to remove the record of unpluggeddevice

[Vivek Goyal]

On Tue, Jul 26, 2011 at 11:40:26AM -0700, Paul Menage wrote:
> On Tue, Jul 26, 2011 at 10:41 AM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> > They have but the context where temp is being used to figure out if it
> > is a deletion rule is generic. So if a rule is being deleted (be it
> > weight, bps or iops), we are going to parse it early in the function.
> > So in that context not calling it "weight" makes sense to me.
> >
> > We use bps, iops names only after knowing the value type.
> 
> Fair enough - but in that case, wouldn't it make sense to make "temp"
> a u64 and just parse it once, rather than reparsing the iops/bps later
> in their switch cases?

Agreed. That makes sense. Make temp u64 and use strict_strtoull() and
once parsed use that value for weight, bps and iops and don't do
parsing again.

Wanlong, could you please take care of above also in your next posting?

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/