Re: [PATCH v3] blk-cgroup:be able to remove the record of unplugged device

[Paul Menage]

On Tue, Jul 26, 2011 at 7:44 AM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
>>       char *s[4], *p, *major_s = NULL, *minor_s = NULL;
>>       int ret;
>> -     unsigned long major, minor, temp;
>> +     unsigned long major, minor, weight;
>
> Do not replace temp with name weight. The place you are parsing it,
> it could be weight, bps or iops. So lets keep the generic name in
> place.

The variable currently called "temp" is only ever stored in
newpn->val.weight. iops and bps already have their own local
variables.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/