Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write

From: Alex Elder
Date: Tue Jul 26 2011 - 11:22:05 EST


On Sun, 2011-07-24 at 14:03 +0200, Markus Trippelsdorf wrote:
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
>
> Signed-off-by: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Tested-by: Christoph Hellwig <hch@xxxxxx>

Finally looking at this I noticed the same thing Christoph
did; thanks for fixing both. Your change got committed
yesterday via Al Viro's VFS tree.

-Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/