Re: [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN()and KCONFIG_MODULE()

[Michal Marek]

On 26.7.2011 15:01, AmÃrico Wang wrote:
> On Tue, Jul 26, 2011 at 6:58 AM, Michal Marek<mmarek@xxxxxxx>  wrote:
> > Replace the config_is_*() macros with a variant that allows for grepping
> > for usage of CONFIG_* options in the code. Usage:
> >
> >   if (KCONFIG(CONFIG_NUMA))
> >
> > or
> >
> >   #if KCONFIG(CONFIG_NUMA)
> >
> > The KCONFIG() macro evaluates to 1 if the argument is set (to either 'y'
> > or 'm'), KCONFIG_BUILTIN() and KCONFIG_MODULE() test if the respective
> > option is 'y' and 'm', respectively.
>
> I think it's better to let KCONFIG_MODULE() returns true only for =m, so that
> KCONFIG() will equal to KCONFIG_BUILTIN() || KCONFIG_MODULE().

This is how it's done.


> BTW, the name KCONFIG(CONFIG_NUMA) seems ugly.

Suggest a better one :). The proposals so far:
config_is_numa() (breaks grep)
CONFIGURED(CONFIG_NUMA)
ENABLED(CONFIG_NUMA)
KCONFIG(CONFIG_NUMA)

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/