Re: [PATCH] OMAP3: NAND: Adding NAND support and specifying NAND partitions.

[Grazvydas Ignotas]

On Mon, Jul 25, 2011 at 4:40 PM, Hrishikesh Bhandiwad
<hrishikesh.b@xxxxxx> wrote:
> This patch adds the NAND support on OMAP3EVM board and also allocates
> five partitions Âon NAND.
> Referred to file: arch/arm/mach-omap2/board-omap3beagle.c
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> Signed-off-by: Sanjeev Premi <premi@xxxxxx>
> Signed-off-by: Hrishikesh Bhandiwad <hrishikesh.b@xxxxxx>
> ---
> Âarch/arm/mach-omap2/board-omap3evm.c | Â 40 ++++++++++++++++++++++++++++++++++
> Â1 files changed, 40 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
> index b4d4346..be45b63 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -30,6 +30,10 @@
> Â#include <linux/usb/otg.h>
> Â#include <linux/smsc911x.h>
>
> +#include <linux/mtd/mtd.h>

You don't need this include.

> +#include <linux/mtd/partitions.h>
> +#include <linux/mtd/nand.h>
> +
> Â#include <linux/wl12xx.h>
> Â#include <linux/regulator/fixed.h>
> Â#include <linux/regulator/machine.h>
> @@ -46,6 +50,8 @@
> Â#include <plat/mcspi.h>
> Â#include <video/omapdss.h>
> Â#include <video/omap-panel-generic-dpi.h>
> +#include <plat/gpmc.h>
> +#include <plat/nand.h>

These 2 too.

>
> Â#include "mux.h"
> Â#include "sdram-micron-mt46h32m32lf-6.h"
> @@ -101,6 +107,37 @@ static void __init omap3_evm_get_revision(void)
> Â Â Â Â}
> Â}
>
> +static struct mtd_partition omap3evm_nand_partitions[] = {
> + Â Â Â /* All the partition sizes are listed in terms of NAND block size */
> + Â Â Â {
> +        .name      = "X-Loader",
> +        .offset     = 0,
> +        .size      = 4 * NAND_BLOCK_SIZE,
> +        .mask_flags   = MTD_WRITEABLE,    Â/* force read-only */
> + Â Â Â },
> + Â Â Â {
> +        .name      = "U-Boot",
> +        .offset     = 0x80000

Missing comma. Have you at least tried compiling this?

> +        .size      = 15 * NAND_BLOCK_SIZE,
> +        .mask_flags   = MTD_WRITEABLE,    Â/* force read-only */
> + Â Â Â },
> + Â Â Â {
> +        .name      = "U-Boot Env",
> +        .offset     = 0x260000
> +        .size      = 1 * NAND_BLOCK_SIZE,
> + Â Â Â },
> + Â Â Â {
> +        .name      = "Kernel",
> +        .offset     = 0x280000
> +        .size      = 32 * NAND_BLOCK_SIZE,
> + Â Â Â },
> + Â Â Â {
> +        .name      = "File System",
> +        .offset     = 0x680000
> +        .size      = MTDPART_SIZ_FULL,
> + Â Â Â },
> +};
> +
> Â#if defined(CONFIG_SMSC911X) || defined(CONFIG_SMSC911X_MODULE)
> Â#include <plat/gpmc-smsc911x.h>
>
> @@ -696,6 +733,9 @@ static void __init omap3_evm_init(void)
>
> Â Â Â Âomap_serial_init();
>
> + Â Â Â omap_nand_flash_init(NAND_BUSWIDTH_16, omap3evm_nand_partitions,
> + Â Â Â Â Â Â Â Â Â Â Â ARRAY_SIZE(omap3evm_nand_partitions));
> +
> Â Â Â Â/* OMAP3EVM uses ISP1504 phy and so register nop transceiver */
> Â Â Â Âusb_nop_xceiv_register();
>
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>

-- 
GraÅvydas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/