Re: [GIT PULL] iscsi-target merge for v3.1-rc1

[Nicholas A. Bellinger]

On Tue, 2011-07-26 at 00:43 -0700, Andrew Morton wrote:
> On Tue, 26 Jul 2011 00:09:40 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Just a simple
> > 
> > #define DIV_ROUND_UP_ULL(ll,d) \
> >   ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; })
> > 
> > looks like it would work and be simpler. Avoid the conditional, do the
> > same "add 'd-1' thing as the regular ROUND_UP().
> > 
> 
> We might end up needing a DIV_ROUND_UP_SECTOR_T because that guy's
> type/size is Kconfigurable.
> 
> otoh DIV_ROUND_UP_ULL won't have many callsites - the occasional
> conversion from UL to ULL then back to UL wouldn't kill us.  Unless
> there be subtle problems with such a conversion.
> 

Makes sense to me, and sending out updated series..  Anything else to
consider here folks before pushing into target-pending.git/for-next..?

Thanks!

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/