Re: [PATCH] dmaengine: imx-sdma: return proper error if kzallocfails

[Vinod Koul]

On Tue, 2011-07-12 at 15:51 +0200, Sascha Hauer wrote:
> On Tue, Jul 12, 2011 at 09:00:13PM +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> > ---
> >  drivers/dma/imx-sdma.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Applied, Thanks

> 
> > 
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> > index 1ea47db..f96d038 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -1281,8 +1281,10 @@ static int __init sdma_probe(struct platform_device *pdev)
> >  		goto err_request_irq;
> >  
> >  	sdma->script_addrs = kzalloc(sizeof(*sdma->script_addrs), GFP_KERNEL);
> > -	if (!sdma->script_addrs)
> > +	if (!sdma->script_addrs) {
> > +		ret = -ENOMEM;
> >  		goto err_alloc;
> > +	}
> >  
> >  	sdma->version = pdata->sdma_version;
> >  
> > -- 
> > 1.7.4.1
> > 
> > 
> > 
> > 
> 

-- 
~Vinod Koul
Intel Corp.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/