Re: [PATCH 2/2] x86, ioapic: Clean up ioapic/apic_id usage

[Ingo Molnar]

* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> 
> While looking at the code, apic_id sometime is referred to index of ioapic, but
> sometime is used for real apic id. and some even use apic for real apic id.
> It is very confusing.
> 
> So try to limit apic_id to be real apic id for ioapic.
> and use ioapic for ioapic index in the array.

Yes, consistency and unambiguity is good - please make it ioapic_id 
and ioapic_idx.

('apic_id' can be confused with a local APIC id, and 'ioapic' can be 
confused with an ioapic ID.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/