Re: [PATCH] rtc-tegra: properly initialize spinlock

From: Thomas Gleixner
Date: Sat Jul 23 2011 - 03:29:25 EST


On Fri, 22 Jul 2011, Sven-Thorsten Dietrich wrote:
>
> On Jul 22, 2011, at 3:13 PM, Andrew Morton wrote:
>
> > On Fri, 22 Jul 2011 10:35:56 +0200
> > Uwe Kleine-K__nig <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> >
> >> Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and
> >> breaks with PREEMPT_RT_FULL.
> >
> > Please define "breaks". Lockdep warnings? Deadlocks?
>
> Narrr, I think its a compile-time problem with the static initializer.

Correct. The macro expansion magic of the static initializer barfs and
with lockdep the lockdep key assignment is missing.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/