Re: [patch 1/3] rtc: Handle errors correctly inrtc_irq_set_state()
From: Thomas Gleixner
Date: Sat Jul 23 2011 - 03:17:33 EST
On Fri, 22 Jul 2011, Andrew Morton wrote:
> On Fri, 22 Jul 2011 09:12:50 -0000
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > The code checks the correctness of the parameters, but unconditionally
> > arms/disarms the hrtimer.
> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxx
> The -stable maintainers will want to know why they should merge this.
> The maintainers of other trees will wonder whether they should backport
> it too.
> To help them make these decision we should always provide a description
> of the user-visible effects of the bug, please.
The result is that a random task might arm/disarm rtc timer and
surprise the real owner by either generating events or by stopping
them. Both undesired behaviour :)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/