Re: [PATCHv2] DMAEngine: Let dmac drivers to set chan_id

From: Jaswinder Singh
Date: Fri Jul 22 2011 - 23:56:39 EST


On 23 July 2011 03:53, Williams, Dan J <dan.j.williams@xxxxxxxxx> wrote:

>
> Unless you guaranteed that every id is globally unique I don't see how
> they are generically usable by common clients?
>
Yes. And the first step is to allow DMAC drivers to freely set chan_id value.
Platform could pass the list and mapping of supported 'global channels'
via platform_data(?) which the DMAC drivers could set in chan_id
And I am not sure of defining a new variable for that, because chan_id
is actually used only by some dmac drivers for internal purpose only -
which they could do by private variables.

Proposal to have global cross-platform enum of channel-IDs defined by
client drivers, was to be my next patch.
Though I think, this patch is valid in it's own light.

-j

--
Linaro.org â Open source software for ARM SoCs | Follow Linaro
http://facebook.com/pages/Linaro/155974581091106 Â-
http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/