Re: [stable] [patch 3/3] rtc: Limit frequency

From: Willy Tarreau
Date: Fri Jul 22 2011 - 18:39:50 EST


On Fri, Jul 22, 2011 at 03:05:50PM -0700, Andrew Morton wrote:
> On Fri, 22 Jul 2011 09:12:51 -0000
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > The RTC hrtimer is self rearming. We really need to limit the
> > frequency to something sensible.
>
> > Cc: stable@xxxxxxxxxx
>
> Why? What failures does the current code cause? What effect do these
> failures have upon users?

I would add that if we go that route, we should at least accept values
that were documented as possible till now. Man rtc says 2 Hz to 8192 Hz,
but Thomas' proposed patch limits it to 5000 Hz, so some breakage is to
be expected.

Regards,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/