Re: [PATCH 1/1] ptrace: do_wait(traced_leader_killed_by_mt_exec) canblock forever

From: Tejun Heo
Date: Fri Jul 22 2011 - 04:44:39 EST


Hello,

On Thu, Jul 21, 2011 at 08:00:43PM +0200, Oleg Nesterov wrote:
> It is racy, exit_notify() does __wake_up_parent() too. But in the
> likely case it triggers the problem: de_thread() does release_task()
> and the old leader goes away without the notification, the tracer
> sleeps in do_wait() without children/tracees.
>
> Change de_thread() to do __wake_up_parent(traced_leader->parent).
> Since it is already EXIT_DEAD we can do this without ptrace_unlink(),
> EXIT_DEAD threads do not exist from do_wait's pov.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Nice catch as always. :)

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/