RE: [PATCH] pstore: change mutex locking to spin_locks

From: Luck, Tony
Date: Thu Jul 21 2011 - 13:57:34 EST

> > Is it safe to call pstore_mkfile with IRQ disabled?
> >
> > pstore_mkfile -> d_alloc_name -> d_alloc -> kmem_cache_alloc(, GFP_KERNEL).
> Don't know. But would that mean we would have to put the pstore_mkfile
> on a workqueue then or something similar?

That might be a good idea anyway. In the "oops" case we'd like the file
to appear in the pstore filesystem if the system stayed healthy despite
the oops[1]. There isn't any reason why the pstore entry must appear instantly.
Delaying the creation would avoid running into problems related to the


[1] So we can remove it to free pstore backend space - if we didn't die
from the oops, then the oops is going to be in /var/log/messages.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at