Re: [PATCH] x86: Fix memory leak of init_vdso_vars()

From: Andi Kleen
Date: Thu Jul 21 2011 - 13:10:28 EST


On Thu, Jul 21, 2011 at 10:33:14AM -0400, Andy Lutomirski wrote:
> From: Zhitong Wang <wzt.wzt@xxxxxxxxx>
>
> If init_vdso_vars ran out of memory (not very likely), then it would
> leak a few pages as well.
>
> Also rename init_vdso_vars to just init_vdso, since initializing
> vvars is just about the only thing this function doesn't do.

Just add a GFP_PANIC, there's no way to recover from this.
Your system will not work without a vdso.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/