Re: [tip:perf/urgent] perf tools, x86: Fix 32-bit compile on 64-bitsystem

[David Ahern]

On 07/21/2011 10:07 AM, H. Peter Anvin wrote:
>> The problem is the detection of the host arch without considering passed in
>> flags. This change fixes 32-bit builds via:
>>
>> make EXTRA_CFLAGS=-m32
>>
>> and 64-bit builds still reference the memcpy_64.S.
>>
> 
> But this is the wrong way to build 32-bit code on 64-bit platforms.
> make ARCH=i386 is the supported way.
> 
> 	-hpa
> 

Indeed that works fine. If that is the preferred route then the patch
needs to update the following comment in the Makefile:

# Define EXTRA_CFLAGS=-m64 or EXTRA_CFLAGS=-m32 as appropriate for
cross-builds.

to specify ARCH on the command line.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/