Re: [PATCH 01/11] MFD: DA9052 MFD core module v2

[Shawn Guo]

On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:
> The DA9052 is a highly integrated PMIC subsystem with supply domain flexibility
> to support wide range of high performance application.
> 
> It provides voltage regulators, GPIO controller, Touch Screen, RTC, Battery
> control and other functionality.
> 
> Signed-off-by: David Dajun Chen <dchen@xxxxxxxxxxx>
> Signed-off-by: Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx>
> ---
[...]
> diff --git a/include/linux/mfd/da9052/pdata.h b/include/linux/mfd/da9052/pdata.h
> new file mode 100755
> index 0000000..75d82a3
> --- /dev/null
> +++ b/include/linux/mfd/da9052/pdata.h
> @@ -0,0 +1,43 @@
> +/*
> + * Platform data declarations for DA9052 PMICs.
> + *
> + * Copyright(c) 2011 Dialog Semiconductor Ltd.
> + *
> + * Author: David Dajun Chen <dchen@xxxxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + *
> + */
> +
> +#ifndef __MFD_DA9052_PDATA_H__
> +#define __MFD_DA9052_PDATA_H__
> +
> +#define DA9052_MAX_REGULATORS	15
> +
> +struct da9052;
> +
> +struct da9052_pdata {
> +	struct led_platform_data *pled;
> +	struct da9052_wdt_platform_data *pwdt;
> +	struct da9052_tsi_platform_data *ptsi;
> +	int (*init) (struct da9052 *da9052);

Do you have any actually example to demonstrate the necessity of
this hook?  Otherwise, I would suggest we drop it, since machine
code can always do whatever setup needed there.

I'm asking because this kind of hooks always get in the way of the
device tree conversion.

Regards,
Shawn

> +	int irq;
> +	int irq_base;
> +	int num_regulators;
> +	int gpio_base;
> +	struct regulator_init_data *regulators[DA9052_MAX_REGULATORS];
> +};

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/