RE: 2.6.33.16 Documentation/lguest breaks compile under debian x86

From: Jean Marc Olivieri
Date: Thu Jul 21 2011 - 11:58:55 EST


Hi,

You were obviously right : zlib1g-dev wasn't installed.
But my point is this library is not used : so why to keep it ?

Best regards

Jean-Marc OLIVIERI
IngÃnieur dÃveloppement
+33 1 41 90 66 55
jmolivieri@xxxxxxxxxx



ALGORIA - Ãditeur de TWS
31, rue Ernest Renan 92130 Issy-les-Moulineaux
+33 1 41 90 66 66 (std) / +33 1 41 90 66 56 (fax)
www.algoria.fr



-----Message d'origine-----
DeÂ: Stratos Psomadakis [mailto:psomas@xxxxxxxxxxx]
EnvoyÃÂ: jeudi 21 juillet 2011 16:57
ÃÂ: Jean Marc Olivieri
CcÂ: linux-kernel@xxxxxxxxxxxxxxx
ObjetÂ: Re: 2.6.33.16 Documentation/lguest breaks compile under debian x86

On 07/21/2011 05:15 PM, Jean Marc Olivieri wrote:
> I'm currently using :
> Distributor ID: Debian
> Description: Debian GNU/Linux 6.0.2 (squeeze)
> Release: 6.0.2
> Codename: squeeze
> On x86 PC.
>
> Kernel 2.6.33.16 fails to compile due to unfound include. Thus I got rid of it and it works.
> I successfully built kernels against :
> - x86
> - x64
>
> Here's the patch :
>
> diff -u -r a/linux-2.6.33.16/Documentation/lguest/lguest.c b/linux-2.6.33.16/Documentation/lguest/lguest.c
> --- a/linux-2.6.33.16/Documentation/lguest/lguest.c 2011-07-13 05:31:47.000000000 +0200
> +++ b/linux-2.6.33.16/Documentation/lguest/lguest.c 2011-07-21 15:16:03.331040033 +0200
> @@ -34,7 +34,6 @@
> #include <sys/uio.h>
> #include <termios.h>
> #include <getopt.h>
> -#include <zlib.h>
> #include <assert.h>
> #include <sched.h>
> #include <limits.h>
>
>
> Jean-Marc OLIVIERI
> IngÃnieur dÃveloppement
> +33 1 41 90 66 55
> jmolivieri@xxxxxxxxxx
>
>
>
> ALGORIA - Ãditeur de TWS
> 31, rue Ernest Renan 92130 Issy-les-Moulineaux
> +33 1 41 90 66 66 (std) / +33 1 41 90 66 56 (fax)
> www.algoria.fr
More recent kernels have removed the zlib.h include (upstream patch
28ff4ef7 [1]), but the patch wasn't included it in the older
-stable/-longterm kernels (obviously ;).

Anyway, you could also install the zlib headers (I think zlib1g-dev in
Debian) to make lguest launcher code compile.

[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=28ff4ef71795fe6f6c0cc06a04911c9ca09c2c11

--
Stratos Psomadakis
<psomas@xxxxxxxxxxx>

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—