Re: [PATCH 3/3] mm: page allocator: Reconsider zones for allocationafter direct reclaim

[Mel Gorman]

On Thu, Jul 21, 2011 at 06:35:40PM +0900, KOSAKI Motohiro wrote:
> Hi
> 
> 
> 
> 
> 
> >> So, I think we don't need to care zonelist, just kswapd turn off
> >> their own node.
> > 
> > I don't understand what you mean by this.
> 
> This was the answer of following your comments.
> 
> > Instead, couldn't we turn zlc->fullzones off from kswapd?
> > >
> > > Which zonelist should it clear (there are two)
> 
> I mean, buddy list is belong to zone, not zonelist. therefore, kswapd
> don't need to look up zonelist.
> 
> So, I'd suggest either following way,
>  - use direct reclaim path, but only clear a zlc bit of zones in reclaimed zonelist, not all. or

We certainly could narrow the number of zones the bits are
cleared on by exporting knowledge of the ZLC to vmscan for use in
shrink_zones(). I think in practice the end result will be the same
though as shrink_zones() examples all zones in the zonelist. How much
of a gain do you expect the additional complexity to give us?

>  - use kswapd and only clear a zlc bit at kswap exiting balance_pgdat
> 

That is potentially a long time if there are streaming readers keeping a
zone under the high watermark for a long time.

> I'm prefer to add a branch to slowpath (ie reclaim path) rather than fast path.
> 

The clearing of the zonelist is already happening after direct reclaim
which is the slow path. What fast path are you concerned with here?

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/