Re: [uml-devel] [PATCH 09/10] um: Ajdust size of pid_buf

[Geert Uytterhoeven]

On Thu, Jul 21, 2011 at 11:18, Richard Weinberger <richard@xxxxxx> wrote:
> Linux can have pids up to 4*1024*1024.
> To handle such huge numbers pid_buf needs to be larger.
>
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> Âarch/um/drivers/harddog_user.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/drivers/harddog_user.c b/arch/um/drivers/harddog_user.c
> index b56f8e0..84dce3f 100644
> --- a/arch/um/drivers/harddog_user.c
> +++ b/arch/um/drivers/harddog_user.c
> @@ -32,7 +32,7 @@ int start_watchdog(int *in_fd_ret, int *out_fd_ret, char *sock)
> Â{
> Â Â Â Âstruct dog_data data;
> Â Â Â Âint in_fds[2], out_fds[2], pid, n, err;
> - Â Â Â char pid_buf[sizeof("nnnnn\0")], c;
> + Â Â Â char pid_buf[sizeof("nnnnnnn\0")], c;

Why not make it handle the full 32-bit? That's just a few bytes extra
on the stack...

> Â Â Â Âchar *pid_args[] = { "/usr/bin/uml_watchdog", "-pid", pid_buf, NULL };
> Â Â Â Âchar *mconsole_args[] = { "/usr/bin/uml_watchdog", "-mconsole", NULL,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂNULL };
> --
> 1.7.6

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/