Re: [BUGFIX] ACPI, APEI, EINJ Param support is disabled by default

[Andi Kleen]

On Thu, Jul 21, 2011 at 10:54:13AM +0800, Huang Ying wrote:
> On 07/21/2011 10:42 AM, Andi Kleen wrote:
> >>  
> >> +static bool param_extension;
> >> +module_param(param_extension, bool, 0);
> > 
> > Make it 0644, then it can be changed at runtime. No need to require a reboot.
> 
> Normally, EINJ is compiled as module, so we can change it at load time
> without a reboot.

Ok. 

> 
> Do we need the real runtime switching capability?

I usually do that with modparams when it's possible. After all it's very
simple and doesn't cost anything.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/