RE: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

From: Andrew Chew
Date: Wed Jul 20 2011 - 18:57:17 EST


> > > +Required properties for type = "utmi".  These values are
> > derived from
> > > +characterization by system engineering.
> > > + - hssync_start_delay
> > > + - idle_wait_delay
> > > + - elastic_limit
> > > + - term_range_adj
> > > + - xcvr_setup
> > > + - xcvr_lsfslew
> > > + - xcvr_lsrslew
> >
> > All of these custom properties should be prefixed with "nvidia," to
> > avoid namespace collisions.
>
> Are you saying we should prefix with "nvidia," on ALL of the
> properties I've defined for the tegra20-ehci node? Or
> specifically those seven that you pointed out? Because I
> don't see a difference in terms of "custom"-ality between
> say, hssync-start-delay, and the other stuff like phy-type,
> mode, power-down-on-bus-suspend, and the reset-gpio and clk
> from phy-type=ulpi...unless we're considering stuff like
> phy-type to be a standard USB host controller node property.

Looking around for precedence, I see that fsl-usb.txt documents a phy-type as well as a dr-mode (though there's still underscores in that document...I assume they will be replaced by hyphens at some point). So I think the tegra2 ehci host driver will mirror that, and use those property names, in which case I assume we don't have a vendor prefix on those. Are "standard" usb host controller properties (those that shouldn't have a vendor prefix) documented anywhere?--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/