Re: [PATCH 2/2] taskstats: add_del_listener() should ignore !validlistener's
From: Vasiliy Kulikov
Date: Wed Jul 20 2011 - 15:46:14 EST
On Wed, Jul 20, 2011 at 21:00 +0200, Oleg Nesterov wrote:
> When send_cpu_listeners() finds the orphaned listener it marks
> it as !valid and drops listeners->sem. Before it takes this sem
> for wrinting, s->pid can be reused and add_del_listener() can
> wrongly try to re-use this entry.
> Change add_del_listener() to check ->valid = T.
I think the current logic is wrong. If s was claimed is invalid, it
then points to a dead task, it is unknown when it died. As the same pid
can be reused by a new process BEFORE add_del_listener(), it is unknown
whether ->pid points to the actual owner task.
Rather than optimizing the wrong algorithm it's better to change the
processes keeping way.
http://www.openwall.com - bringing security into open computing environments
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/